Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Un-pythonic code #1

@ajrbyers

Description

@ajrbyers
    def truncated_filename(self):
        name, extension = os.path.splitext(self.original_filename)
        file_name=''
        if len(name)>14:
            file_name=name[:14]+'...'+' '+extension
        else:
            file_name=name+extension

        return file_name
    def truncated_filename_long(self):
        name, extension = os.path.splitext(self.original_filename)
        file_name=''
        if len(name)>32:
            file_name=name[:32]+'...'+' '+extension
        else:
            file_name=name+extension

        return file_name    

    def truncated_label(self):
        name = str(self.label)
        if len(name)>=22:
            name = name[:22]+'...'
        return name

This block of code is not very pythonic. We don't use + to concatenate strings. Update to use %s please!

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions