-
Notifications
You must be signed in to change notification settings - Fork 90
Open
Description
If a ArgReader is closed without reading all data, it returns an error:
tchannel-go/fragmenting_reader.go
Line 200 in a815a8e
| r.err = errMoreDataInArgument |
This does not close the underlying message exchange, so as far as the channel is concerned, there's a pending call. However, this pending call can never be cleared, since all further operations return the same error.
We should close the message exchange on any errors,
Line 235 in a815a8e
| func (mex *messageExchange) shutdown() { |
That will ensure that the channel close isn't blocked.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels