-
Notifications
You must be signed in to change notification settings - Fork 43
Open
Description
This makes using Kotlin code generation mode impossible when allWarningsAsErrors is enabled. See #205. This time it's because the generated method signature doesn't match for binds factory methods.
A few requests to address this:
- Fix or suppress the warning in generated code (similar to PR above).
- Enable
allWarningsAsErrorsin Kotlin codegen test suite. - Add a note in https://github.com/uber/motif/wiki#code-generation-mode for Gradle/Kotlin users (looking up how to set this was a bit painful):
kapt { arguments { arg("motif.mode", "java") } }
Library version:
0.3.4
Repro steps or stacktrace:
Add a binds factory method:
@Expose
fun foo(fooImpl: FooImpl): FooCompile warning:
w: <redacted>: The corresponding parameter in the supertype 'Objects' is named 'fooImpl'. This may cause problems when calling this function with named arguments.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels