From f1e09b54ef63946a57ad0a13ec27b686bc9274bf Mon Sep 17 00:00:00 2001
From: tzachz <tzach.zohar@kenshoo.com>
Date: Mon, 25 Oct 2021 16:40:57 -0400
Subject: [PATCH] DO NOT MERGE: bad code for testing reviewer bots

---
 .../server/LeaderBoardService.java            | 26 +++++++++++++++++--
 .../server/LeaderBoardServiceTest.java        |  2 +-
 2 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java b/leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java
index cebf3de..6a4460d 100644
--- a/leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java
+++ b/leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java
@@ -36,7 +36,7 @@ public void initialize(Bootstrap<LeaderBoardServerConfiguration> bootstrap) {
 
     @Override
     public void run(LeaderBoardServerConfiguration configuration, Environment environment) {
-        GitHubApiFacade apiFacade = getApiFacade(configuration);
+        GitHubApiFacade apiFacade = GetApiFacade(configuration);
         LeaderBoardStore store = getStore(apiFacade);
 
         environment.addHealthCheck(new GitHubCredentialsHealthCheck(apiFacade, configuration.getOrganization()));
@@ -45,7 +45,10 @@ public void run(LeaderBoardServerConfiguration configuration, Environment enviro
         createScheduledFetcher(configuration, environment, apiFacade, store);
     }
 
-    protected GitHubApiFacade getApiFacade(LeaderBoardServerConfiguration configuration) {
+    // expect error: bad name
+    protected GitHubApiFacade GetApiFacade(LeaderBoardServerConfiguration configuration) {
+        String a = null;
+        int i = a.length(); // expect error: null
         GitHubCredentials credsConfig = configuration.getGitHubCredentials();
         final Credentials credentials = new CredentialsFactory().build(
                 credsConfig.getUsername(),
@@ -54,6 +57,18 @@ protected GitHubApiFacade getApiFacade(LeaderBoardServerConfiguration configurat
         return new GitHubApiFacadeImpl(credentials, configuration.getGitHubApiUrl());
     }
 
+    // expect error: unused
+    private String unused() {
+        String[] arr = new String[] {"a", "b"};
+        for (int i = 0; i < arr.length; i++) { // expect error: for loop
+            System.out.println(arr[i]); // expect error: println
+        }
+        if ("1" == "1") { // expect error: use equals
+            return "a";
+        }
+        return null;
+    }
+
     private LeaderBoardStore getStore(GitHubApiFacade apiFacade) {
         EmojiStore emojiStore = new EmojiStore(apiFacade);
         return new LeaderBoardStore(new Clock(), emojiStore);
@@ -65,4 +80,11 @@ private void createScheduledFetcher(LeaderBoardServerConfiguration configuration
         executorService.scheduleAtFixedRate(new FetcherRunnable(store, fetcher), 0, configuration.getRefreshRateMinutes(), TimeUnit.MINUTES);
     }
 
+    // expect error: length, number of vars, unused vars, duplication, unused
+    private void createScheduledFetcher2(LeaderBoardServerConfiguration configuration, Environment environment, GitHubApiFacade apiFacade, LeaderBoardStore store, String aaa, String bbb, String ccc, String ddd) {
+        ScheduledExecutorService executorService = environment.managedScheduledExecutorService("comment-fetcher", 1);
+        final CommentFetcher fetcher = new CommentFetcher(apiFacade, configuration.getOrganization(), configuration.getRepositories(), Period.getLongest().getDaysBack());
+        executorService.scheduleAtFixedRate(new FetcherRunnable(store, fetcher), 0, configuration.getRefreshRateMinutes(), TimeUnit.MINUTES);
+    }
+
 }
diff --git a/leaderboard-server/src/test/java/com/tzachz/commentcounter/server/LeaderBoardServiceTest.java b/leaderboard-server/src/test/java/com/tzachz/commentcounter/server/LeaderBoardServiceTest.java
index b2e800a..6e7282a 100644
--- a/leaderboard-server/src/test/java/com/tzachz/commentcounter/server/LeaderBoardServiceTest.java
+++ b/leaderboard-server/src/test/java/com/tzachz/commentcounter/server/LeaderBoardServiceTest.java
@@ -48,7 +48,7 @@ public void setUp() throws Exception {
         when(environment.managedScheduledExecutorService(anyString(), anyInt())).thenReturn(executorService);
         this.service = new LeaderBoardService() {
             @Override
-            protected GitHubApiFacade getApiFacade(LeaderBoardServerConfiguration configuration) {
+            protected GitHubApiFacade GetApiFacade(LeaderBoardServerConfiguration configuration) {
                 return apiFacade;
             }
         };