Skip to content
This repository was archived by the owner on Feb 12, 2018. It is now read-only.
This repository was archived by the owner on Feb 12, 2018. It is now read-only.

Why #icomoon and ?#iefix stuff in the templates? #4

@eush77

Description

@eush77

The URL for SVG version of a font in src property of @font-face is appended with #icomoon suffix, but what if I have my own SVG font, not affiliated with Icomoon?

src: {{#fonts.eot}}url("{{{fonts.eot}}}?#iefix") format("embedded-opentype"),
     {{/fonts.eot}}{{#fonts.woff}}url("{{{fonts.woff}}}") format("woff"),
     {{/fonts.woff}}{{#fonts.ttf}}url("{{{fonts.ttf}}}") format("truetype"),
     {{/fonts.ttf}}{{#fonts.svg}}url("{{{fonts.svg}}}#icomoon") format("svg"){{/fonts.svg}};

IMO the module should not depend on any vendor extensions. If the filename is foo.svg#icomoon, then it should be assigned to fonts.svg as it is. (And what a strange name btw.)

The same holds true for ?#iefix.

This module can certainly be more useful be it a bit more generic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions