-
Notifications
You must be signed in to change notification settings - Fork 83
Improve Front Matter URL parsing, support Tweet IDs #221
Description
What happened?
It's common to expect users to be unaware that the URL needs to be perfectly formed, and may be copy and pasting from various environments, such as mobile, or from a browser that does not strip trackers from the URL.
After testing pull requests with various URLs passed to the retweet option, the preview check returned "valid", but after merging the tweet failed to published.
What did you expect to happen?
The preview should fail if the URL is not formed correctly, or the publish action should parse the URL properly before retweeting it.
Additionally
An alternative approach is to ignore URLs entirely, and / or accept the Tweet ID.
---
retweet: 1575820698877980672
---
Tests
URL with Hash
IstoraMandiri/twitter-together-testing#8
PREVIEW PASSING: https://github.com/IstoraMandiri/twitter-together-testing/actions/runs/3168205724
PUBLISH FAILING: https://github.com/IstoraMandiri/twitter-together-testing/actions/runs/3168209652
---
retweet: https://twitter.com/testing_tt_/status/1576462993302372355#blah
---
URL with Mock Tracker
IstoraMandiri/twitter-together-testing#9
PREVIEW PASSING: https://github.com/IstoraMandiri/twitter-together-testing/actions/runs/3168218932
PUBLISH FAILING: https://github.com/IstoraMandiri/twitter-together-testing/actions/runs/3168219858
---
retweet: https://twitter.com/testing_tt_/status/1576508832418873349?cxt=xxx
---
URL with mobile subdomain
IstoraMandiri/twitter-together-testing#10
PREVIEW PASSING: https://github.com/IstoraMandiri/twitter-together-testing/actions/runs/3168231352
PUBLISH FAILING: https://github.com/IstoraMandiri/twitter-together-testing/actions/runs/3168233222
---
retweet: https://mobile.twitter.com/testing_tt_/status/1575820698877980672
---