From 3c2a570a2225470e6135273786da14a3489178ca Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Fri, 3 Oct 2025 20:38:28 +0200 Subject: [PATCH 1/2] Remove useless zval_ptr_dtor() in php_userstreamop_write() At this point, retval is either false or converted to a long. --- main/streams/userspace.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/main/streams/userspace.c b/main/streams/userspace.c index 888e4c90bbaf..deae2ff5d2d3 100644 --- a/main/streams/userspace.c +++ b/main/streams/userspace.c @@ -602,8 +602,6 @@ static ssize_t php_userstreamop_write(php_stream *stream, const char *buf, size_ didwrite = count; } - zval_ptr_dtor(&retval); - return didwrite; } From bcb56122b967b640077be62d3ebadd0f9fceead4 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Fri, 3 Oct 2025 20:39:33 +0200 Subject: [PATCH 2/2] Remove useless zval_ptr_dtor() in user_filter_factory_create() At this point, retval is false. --- ext/standard/user_filters.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ext/standard/user_filters.c b/ext/standard/user_filters.c index 5bc4d791bcf6..40ad6a5da37d 100644 --- a/ext/standard/user_filters.c +++ b/ext/standard/user_filters.c @@ -301,9 +301,6 @@ static php_stream_filter *user_filter_factory_create(const char *filtername, if (Z_TYPE(retval) != IS_UNDEF) { if (Z_TYPE(retval) == IS_FALSE) { - /* User reported filter creation error "return false;" */ - zval_ptr_dtor(&retval); - /* Kill the filter (safely) */ ZVAL_UNDEF(&filter->abstract); php_stream_filter_free(filter);