Invitation Code Bug

[AliSchlereth]

As and admin
When I invite a new user as a Student
And the cohort is 'finished'
Then the invitation is invalid
Then I see a red flash message telling me why the invitation is invalid.

[srt32]

@AliSchlereth could you help explain this one too? Why is inviting to a closed cohort invalid?

[bcgoss]

@srt32 can you remind me what the cohort statuses can be? If I recall, the status is marked "closed" after the cohort has completed Turing. It would not really make sense to add new Students to a cohort that's finished right? We want to add new students to active cohorts. Alumni can be members of completed cohorts.

[srt32]

Cohorts now live in Enroll and can be open or closed - https://github.com/turingschool/enroll/blob/master/app/models/cohort.rb#L13

You're right it doesn't make business process sense to invite someone to a closed cohort but I'm not sure why we'd need to encode that rule. Have we had issues in the past?

[bcgoss]

Maybe @AliSchlereth has a better reason, I vaguely remember the customer (Jeff ) asking for better feedback/protection when people are invited.

[AliSchlereth]

@srt32 I believe I wrote invalid in the case that someone had selected the wrong cohort or role. I believe currently if you invite someone as student to a closed cohort they get an error on login.

I would want to be able to invite someone with a role of mentor and a closed cohort since alumni pre 1608 are not in Census but would likely want to be able to group all students past and present by cohort.

I think it was intended that Mentorship would use Census and therefore we need mentor functionality.

[srt32]

Is a work around to this issue to invite mentor users without a cohort and have them assign themselves a cohort by editing their profile once they've logged in (is that possible)?

Another option, since invites happen by admins, perhaps we should give them the power to invite to a closed cohort since they (probably) know what they are doing?

[AliSchlereth]

I can't remember more of the details right now, I'd have to go back and re-create. I believe it broke when someone who was invited to a closed cohort tried to log in. I can't remember what broke, but it might be as simple as adjusting the role someone from a closed cohort would get or updating permissions.

I might have some time tomorrow to try to reproduce this bug and see what the logs say. It might help us figure out how best to solve it.