Decoding of SMS-STATUS-REPORT PDUs

[topac]

SMS-STATUS-REPORT PDU is not properly decoded right now. I tried to tweak your code to make decode it properly. This is only a draft:

      # This code is only valid for SMS-STATUS-REPORT PDUs

      @sca_length = take(2, :integer) * 2                # Service center address length
      if @sca_length > 0
        @sca_type = parse_address_type take(2)            # Service center address type
        @sca = parse_address take(@sca_length - 2), @sca_type, @sca_length # Service center address
      end

      @pdu_type = parse_pdu_type take(2, :binary)   # PDU type octet
      @message_reference = take(2, :integer)

      @address_length = take(2, :integer)

      @address_type = parse_address_type take(2)
      if [:national, :international].include? @address_type
        @address_length = @address_length.odd? ? @address_length + 1 : @address_length # Always take byte aligned - hexdecimal F is added when odd number
      end

      @address = parse_address take(@address_length), @address_type, @address_length

      @sc_timestamp = parse_7byte_timestamp take(14)

      discharge_time = parse_7byte_timestamp take(14)
      status = take(1, :integer)

[tulak]

Do you have some example of that kind of PDU ?

[topac]

Here's an example: 0006DD0C91933371338731516003112440805160031124608000
I've changed the source phone number with a random one for privacy reasons.

The decoder should be able to provide (along with all the other pdu fields) these two important values:

• TP-DT known as Discharge_Time
• TP-ST known as Status

By the way, your gem has been very useful to me. Keep up with the good work!