Skip to content

Validate resource in addPermissionToRole #15

@broom9

Description

@broom9

When calling addPermissionToRole, if one of the resources is undefined, it would lead to an error

TypeError: Cannot read property 'split' of undefined
      at AccessAuthorizer.filterRelevantPermissions (node_modules/@bluejay/access-control/src/classes/access-authorizer.js:60:62)
      at AccessAuthorizer.authorize (node_modules/@bluejay/access-control/src/classes/access-authorizer.js:21:42)
      at AccessControl.<anonymous> (node_modules/@bluejay/access-control/src/classes/access-control.js:20:42)

You should be able to reproduce by codes like this:

store.addPermissionToRole('some_role', {
    id: 'read',
    effect: PermissionEffect.ALLOW,
    resource: [undefined],
    action: ['read']
  });

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions