Skip to content

add nopin option to omit pins rendering in mountedpcbmodule #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techmannih merged 2 commits into from
Jan 31, 2026
Merged

add nopin option to omit pins rendering in mountedpcbmodule #494

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4be23e3
add nopin option to omit pins rendering in mountedpcbmodule
rushabhcodes Jan 31, 2026
95613ab
refactor: format nopin option for better readability in mountedpcbmodule
rushabhcodes Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/fn/mountedpcbmodule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ export const mountedpcbmodule_def = base_def
id: length.default("1.0mm").describe("inner diameter"),
od: length.default("1.5mm").describe("outer diameter"),
male: z.boolean().optional().describe("the module uses male headers"),
nopin: z
.boolean()
.optional()
.default(false)
.describe("omit pins rendering"),
Comment on lines +26 to +30
Copy link

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nopin property is defined in the schema but is never extracted from the parameters object or used in the rendering logic. This means setting nopin: true will have no effect on the output.

To implement this feature properly, you need to:

  1. Extract nopin from the parameters object (around line 226-254)
  2. Use it to conditionally skip pin rendering in the addPin function (around line 271-332) and the pin rendering loops (around lines 410-481)

For example, the addPin function should check if (parameters.nopin) return; at the beginning, or the calls to addPin should be wrapped in a condition like if (!parameters.nopin) { addPin(...); }.

Suggested change
nopin: z
.boolean()
.optional()
.default(false)
.describe("omit pins rendering"),

Copilot uses AI. Check for mistakes.
female: z.boolean().optional().describe("the module uses female headers"),
smd: z.boolean().optional().describe("surface mount device"),
pinlabeltextalignleft: z.boolean().optional().default(false),
Expand Down