From 7d442932dfd8d7d5b008cfab781bed12f93acfcb Mon Sep 17 00:00:00 2001 From: Jon Cherry <53948466+joncherry@users.noreply.github.com> Date: Mon, 17 Nov 2025 13:24:35 -0800 Subject: [PATCH 1/4] fix: add footprint test for spdip-28 --- tests/__snapshots__/dip28_w7.62mm_p2.54mm.snap.svg | 1 + tests/dip.test.ts | 8 ++++++++ 2 files changed, 9 insertions(+) create mode 100644 tests/__snapshots__/dip28_w7.62mm_p2.54mm.snap.svg diff --git a/tests/__snapshots__/dip28_w7.62mm_p2.54mm.snap.svg b/tests/__snapshots__/dip28_w7.62mm_p2.54mm.snap.svg new file mode 100644 index 00000000..9d423095 --- /dev/null +++ b/tests/__snapshots__/dip28_w7.62mm_p2.54mm.snap.svg @@ -0,0 +1 @@ +{REF}{pin1}{pin2}{pin3}{pin4}{pin5}{pin6}{pin7}{pin8}{pin9}{pin10}{pin11}{pin12}{pin13}{pin14}{pin15}{pin16}{pin17}{pin18}{pin19}{pin20}{pin21}{pin22}{pin23}{pin24}{pin25}{pin26}{pin27}{pin28} \ No newline at end of file diff --git a/tests/dip.test.ts b/tests/dip.test.ts index e6b24342..611da598 100644 --- a/tests/dip.test.ts +++ b/tests/dip.test.ts @@ -103,3 +103,11 @@ test("dip_0.1in", () => { const svgContent = convertCircuitJsonToPcbSvg(circuitJson) expect(svgContent).toMatchSvgSnapshot(import.meta.path, "dip_0.1in") }) + +test("dip28_w7.62mm_p2.54mm", () => { + const circuitJson = fp + .string("dip28_w7.62mm_p2.54mm") + .circuitJson() as AnyCircuitElement[] + const svgContent = convertCircuitJsonToPcbSvg(circuitJson) + expect(svgContent).toMatchSvgSnapshot(import.meta.path, "dip28_w7.62mm_p2.54mm") +}) From 44a04b5942cf5b556a41656dc9cf9feb798a5edd Mon Sep 17 00:00:00 2001 From: Jon Cherry <53948466+joncherry@users.noreply.github.com> Date: Mon, 17 Nov 2025 13:37:14 -0800 Subject: [PATCH 2/4] chore: fix format --- tests/dip.test.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/dip.test.ts b/tests/dip.test.ts index 611da598..693387e5 100644 --- a/tests/dip.test.ts +++ b/tests/dip.test.ts @@ -109,5 +109,8 @@ test("dip28_w7.62mm_p2.54mm", () => { .string("dip28_w7.62mm_p2.54mm") .circuitJson() as AnyCircuitElement[] const svgContent = convertCircuitJsonToPcbSvg(circuitJson) - expect(svgContent).toMatchSvgSnapshot(import.meta.path, "dip28_w7.62mm_p2.54mm") + expect(svgContent).toMatchSvgSnapshot( + import.meta.path, + "dip28_w7.62mm_p2.54mm", + ) }) From 16b0d1be309777295ba7b3a632f37170e6da07fb Mon Sep 17 00:00:00 2001 From: Jon Cherry <53948466+joncherry@users.noreply.github.com> Date: Mon, 17 Nov 2025 13:48:59 -0800 Subject: [PATCH 3/4] chore: put new test in separate file --- tests/dip.test.ts | 11 ----------- tests/dip2.test.ts | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 11 deletions(-) create mode 100644 tests/dip2.test.ts diff --git a/tests/dip.test.ts b/tests/dip.test.ts index 693387e5..e6b24342 100644 --- a/tests/dip.test.ts +++ b/tests/dip.test.ts @@ -103,14 +103,3 @@ test("dip_0.1in", () => { const svgContent = convertCircuitJsonToPcbSvg(circuitJson) expect(svgContent).toMatchSvgSnapshot(import.meta.path, "dip_0.1in") }) - -test("dip28_w7.62mm_p2.54mm", () => { - const circuitJson = fp - .string("dip28_w7.62mm_p2.54mm") - .circuitJson() as AnyCircuitElement[] - const svgContent = convertCircuitJsonToPcbSvg(circuitJson) - expect(svgContent).toMatchSvgSnapshot( - import.meta.path, - "dip28_w7.62mm_p2.54mm", - ) -}) diff --git a/tests/dip2.test.ts b/tests/dip2.test.ts new file mode 100644 index 00000000..0360215d --- /dev/null +++ b/tests/dip2.test.ts @@ -0,0 +1,15 @@ +import { test, expect } from "bun:test" +import { convertCircuitJsonToPcbSvg } from "circuit-to-svg" +import { fp } from "../src/footprinter" +import type { AnyCircuitElement } from "circuit-json" + +test("dip28_w7.62mm_p2.54mm", () => { + const circuitJson = fp + .string("dip28_w7.62mm_p2.54mm") + .circuitJson() as AnyCircuitElement[] + const svgContent = convertCircuitJsonToPcbSvg(circuitJson) + expect(svgContent).toMatchSvgSnapshot( + import.meta.path, + "dip28_w7.62mm_p2.54mm", + ) +}) \ No newline at end of file From 850b9014714cae5bf0df9213fcd649633a25dd79 Mon Sep 17 00:00:00 2001 From: Jon Cherry <53948466+joncherry@users.noreply.github.com> Date: Mon, 17 Nov 2025 13:49:46 -0800 Subject: [PATCH 4/4] chore: fix format again --- tests/dip2.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/dip2.test.ts b/tests/dip2.test.ts index 0360215d..89878855 100644 --- a/tests/dip2.test.ts +++ b/tests/dip2.test.ts @@ -12,4 +12,4 @@ test("dip28_w7.62mm_p2.54mm", () => { import.meta.path, "dip28_w7.62mm_p2.54mm", ) -}) \ No newline at end of file +})