-
Notifications
You must be signed in to change notification settings - Fork 19
Description
Éric Vyncke has entered the following ballot position for
draft-ietf-teas-rfc8776-update-20: DiscussWhen responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)
Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/
for more information about how to handle DISCUSS and COMMENT positions.The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-teas-rfc8776-update/
DISCUSS:
Éric Vyncke INT AD comments for draft-ietf-teas-rfc8776-update-20
CC @evyncke
Thank you for the work put into this document.
Please find below one blocking DISCUSS points, some non-blocking COMMENT
points/nits (replies would be appreciated even if only for my own education).Special thanks to Oscar Gonzalez de Dios for the shepherd's write-up including
the WG consensus and the justification of the intended status.I hope that this review helps to improve the document,
Regards,
-éric
Note: this ballot comments follow the Markdown syntax of
https://github.com/mnot/ietf-comments/tree/main, i.e., they can be processed by
a tool to create github issues.DISCUSS (blocking)
As noted in
https://datatracker.ietf.org/doc/statement-iesg-handling-ballot-positions-20220121/,
a DISCUSS ballot is a request to have a discussion on the points below; I
really think that the document would be improved with a change here, but can be
convinced otherwise.Title
While I understand that the TEAS WG is limited to MPLS technology, the title of
this IETF draft is misleading as it it notCommon YANG Data Types for Traffic Engineeringbut more aboutCommon YANG Data Types for *MPLS-based* Traffic Engineering.This also applies to the module names as they should include "mpls" in the name
as they are specific to MPLS and in no wayietf-te-types, or did I miss
something?Even if RFC 8776 had the some issue, this is not a reason for repeating the
confusion.More broadly, I find extremely sad that there is IETF-wide effort to have a
real common data model across all TE control planes :-(Section 3.1
The leading text contains
TE types that are independent and agnostic of any specific technology or control-plane instancebut its subsection has terms
that are very specific to MPLS-based control planes, e.g.,lsp-encoding-types.Section 3.1.1
Missing text about when the SHOULD can be bypassed or what are the consequences
of bypassing it in:The derived identities SHOULD describe the unit and maximum value of the path metric types they defineper
https://datatracker.ietf.org/doc/statement-iesg-statement-on-clarifying-the-use-of-bcp-14-key-words/Section 3.1.2
What is
16-octet in full, mixed, shortened, or shortened-mixed IPv6 address notation? Why not simply requesting to use RFC 5952 ?Same applies to
te-node-idin sectionSection 4
It is unclear what is "hex float" in
where each of these numbers can be non-negative decimal, hex integer, or *hex float*in the description
ofte-bandwidth. There is a hint to'bandwidth-ieee-float32'but it should
not be a hint.
COMMENT:
COMMENTS (non-blocking)
Section 2
It would have been useful to also provide references to the terms beyond acronyms expansions.
Section 3.1.1.1
Please expand or add a reference to "RWA" in
No RWA constraints met
See: https://mailarchive.ietf.org/arch/msg/teas/tMTDQbdBdXHTOA6OAstCohlMXro/