Skip to content

Clarify Rate Sampling config #300

@joe-warren

Description

@joe-warren

The documentation for RateSpanSampler, states that it uses a Token Bucket algorithm, and lists the Token Bucket parameters as bucketSize (an Integer) and tokenRate (a Duration).

My reading of the Token Bucket algorithim is that the effective rate limit is bucketSize spans every tokenRate time period (per pod/instance/etc). I think this would be worth explicitly stating?

I also personally feel like the example values (bucketSize = 100, tokenRate = 10.millis) are a little high for trace collection, and a stricter rate limit might make for a better example?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions