Review errortype branch

[richardhodgson]

Following on from my comment... https://github.com/tomyan/use.no.de/issues/2#issuecomment-1414209

I've added an error type to Spectrum, in a branch:
master...errortypes

It allows you do something like this in your code:

spectrum.loadTemplate('does-not-exist.spv').then(
    function () {
        // all is fine...
    },
    function (e) {
        if (e.type == spectrum.errors.couldNotReadTemplate) {
            // handle missing template 
        }
        else {
            // some other error
        }
    }
);

What do you think?

[tomyan]

Sounds like a good plan. Do you prefer the above, or:

if (e instanceof spectrum.errors.CouldNotReadTemplate) {
    // ...
}

?

[richardhodgson]

I prefer the latter, less things to write and maintain.

Will update when I get a chance.

On 4 Jul 2011, at 08:41, tomyanreply@reply.github.com wrote:

Sounds like a good plan. Do you prefer the above, or:

if (e instanceof spectrum.errors.CouldNotReadTemplate) {
// ...
}

?

Reply to this email directly or view it on GitHub:
#2 (comment)