Skip to content

fix: resolve UDP port binding issue #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomhobson merged 1 commit into from
Nov 7, 2025
Merged

fix: resolve UDP port binding issue #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Sergen.Core/Services/Containers/Docker/DockerInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@
}
}

private async Task CreateDirectoriesIfNotExist(string path)

Check warning on line 176 in src/Sergen.Core/Services/Containers/Docker/DockerInterface.cs

View workflow job for this annotation

GitHub Actions / build 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 176 in src/Sergen.Core/Services/Containers/Docker/DockerInterface.cs

View workflow job for this annotation

GitHub Actions / build 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
if(Directory.Exists(path) == false)
{
Expand Down Expand Up @@ -401,7 +401,7 @@
string internalPortAssignment = port.Key;
if (port.Value == "udp")
{
portAssignment = $"{portNumber.ToString()}/{port.Value}";
portAssignment = portNumber.ToString();
internalPortAssignment = $"{port.Key}/{port.Value}";
}

Expand All @@ -414,7 +414,7 @@
portBindings, portsToExpose);
}

private async Task<IList<string>> GenerateEnvironmentVariables(GameServer gameServer)

Check warning on line 417 in src/Sergen.Core/Services/Containers/Docker/DockerInterface.cs

View workflow job for this annotation

GitHub Actions / build 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
// Assign the environment variables to the container
var env = new List<string>();
Expand Down Expand Up @@ -442,4 +442,4 @@
return env;
}
}
}
}
Loading