Skip to content

'/search' endpoint broken #5

@pacMakaveli

Description

@pacMakaveli

Hey,

It looks like the '/search' endpoint is broken and instead of requesting http://giantbomb.com/api/search? it goes to http://giantbomb.com/search which in turn returns HTML instead of JSON.

I managed to fix this with:

    def end_point
      GiantBombApi::Client::API_URL + 'search'
    end

I wanted to make a pull request but I'm not sure this is the proper way to fix this. Maybe we need to understand why GiantBombApi::Request::Search doesn't use API_URL when making a request instead of hardcoding the full URL in the class.

I tried to have a look through the code but to be honest it's a bit complicated for me and I don't really have the time to properly learn how it works.

Thanks

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions