changed coverage option to ignore only *Codecs

Author: abrighton

esw-agent-pekko/esw-agent-pekko-app/src/main/scala/esw/agent/pekko/app/AgentWiring.scala

@@ -43,10 +43,10 @@ class AgentWiring(agentSettings: AgentSettings, hostConfigPath: Option[String],
   private lazy val configUtils         = new ConfigUtils(configClientService)
   private lazy val versionManager      = new VersionManager(agentSettings.versionConfPath, configUtils)
 
-  lazy val processOutput   = new ProcessOutput()
-  lazy val processExecutor = new ProcessExecutor(processOutput)
-  lazy val processManager  = new ProcessManager(locationService, versionManager, processExecutor, agentSettings)
-  lazy val agentActor      = new AgentActor(processManager, configUtils, hostConfigPath, isConfigLocal)
+  lazy val processOutput      = new ProcessOutput()
+  lazy val processExecutor    = new ProcessExecutor(processOutput)
+  lazy val processManager     = new ProcessManager(locationService, versionManager, processExecutor, agentSettings)
+  private lazy val agentActor = new AgentActor(processManager, configUtils, hostConfigPath, isConfigLocal)
 
   lazy val lazyAgentRegistration: Future[RegistrationResult] =
     locationService.register(PekkoRegistrationFactory.make(agentConnection, agentRef))

esw-agent-pekko/esw-agent-pekko-app/src/test/scala/esw/agent/pekko/app/AgentCliCommandTest.scala

@@ -0,0 +1,16 @@
+//package esw.agent.pekko.app
+//
+// XXX TODO FIXME
+//import csw.prefix.models.Prefix
+//import org.scalatest.funsuite.AnyFunSuiteLike
+//
+//class AgentCliCommandTest extends AnyFunSuiteLike {
+//
+//  test("testPrefixParser") {
+//    val prefix = "ESW.test"
+////    val hostConfigPath = None
+////    val local = true
+////    val s = AgentCliCommand.StartOptions(prefix, hostConfigPath, local)
+//    assert(AgentCliCommand.prefixParser.parse(prefix, 0, 0) == Prefix("ESW.test"))
+//  }
+//}

esw-agent-pekko/esw-agent-pekko-client/src/main/scala/esw/agent/pekko/client/AgentPekkoSerializer.scala

@@ -7,14 +7,15 @@ import esw.agent.service.api.models.AgentResponse
 import io.bullet.borer.Codec
 import io.bullet.borer.derivation.MapBasedCodecs.deriveCodec
 
+//noinspection ScalaUnusedSymbol
 // $COVERAGE-OFF$
 /*
  * Serializer being used in ser(de) of agents actor messages
  */
 class AgentPekkoSerializer extends CborPekkoSerializer[AgentPekkoSerializable] with AgentActorCodecs {
   override def identifier: Int = 26726
 
-  // for some reason scala3 is not able to infer this from the original location hence moved here
+  // for some reason, scala3 is not able to infer this from the original location hence moved here
   implicit lazy val agentResponseCodec: Codec[AgentResponse] = deriveCodec
 
   register[AgentRemoteCommand]

esw-agent-pekko/esw-agent-pekko-client/src/test/scala/esw/agent/pekko/client/AgentPekkoSerializerTest.scala

@@ -0,0 +1,23 @@
+//package esw.agent.pekko.client
+//
+//import org.scalatest.funsuite.AnyFunSuiteLike
+//import esw.agent.service.api.models.{AgentResponse, Failed}
+//import org.scalatest.BeforeAndAfterAll
+//
+// XXX TODO FIXME
+//class AgentPekkoSerializerTest extends AnyFunSuiteLike {
+//
+//  test("Should serialize and deserialize") {
+//    val s = AgentPekkoSerializer()
+//    import s.*
+//    val t: AgentResponse = Failed("test")
+//    val b                = toBinary(t)
+//    try {
+//      fromBinary(b, Some(Failed.getClass)).asInstanceOf[Failed]
+//    }
+//    catch {
+//      case e: Exception =>
+//        e.printStackTrace()
+//    }
+//  }
+//}

esw-sm/esw-sm-impl/src/test/scala/esw/sm/impl/utils/AgentUtilTest.scala

@@ -150,11 +150,13 @@ class AgentUtilTest extends BaseTestSuite {
 
       val response = agentUtil.provision(provisionConfig).futureValue
       response shouldBe a[ProvisionResponse.SpawningSequenceComponentsFailed]
-      val failureMgs = response.asInstanceOf[ProvisionResponse.SpawningSequenceComponentsFailed].failureResponses.head
+      val instance   = response.asInstanceOf[ProvisionResponse.SpawningSequenceComponentsFailed]
+      val failureMgs = instance.failureResponses.head
       // assert that failure msg has necessary info
       failureMgs.contains(eswPrimaryMachine.prefix.toString()) shouldBe true
       failureMgs.contains(eswSeqComp2Name) shouldBe true
       failureMgs.contains(errorMsg) shouldBe true
+      instance.msg shouldEqual s"Failed to provision: spawning sequence components failed with ${instance.failureResponses}"
 
       verify(locationServiceUtil).listPekkoLocationsBy(Machine)
       verify(agentAllocator).allocate(provisionConfig, machines)
@@ -203,6 +205,7 @@ class AgentUtilTest extends BaseTestSuite {
       when(versionManager.getScriptVersion).thenReturn(Future.failed(FetchingScriptVersionFailed(errorMsg)))
 
       agentUtil.provision(provisionConfig).futureValue should ===(ProvisionVersionFailure(errorMsg))
+      ProvisionVersionFailure(errorMsg).msg should ===(s"Failed to provision: error in fetching version $errorMsg")
     }
   }
 

project/Common.scala

@@ -82,7 +82,8 @@ object Common {
         aggregate,              // verify if this needs to be here or our configuration is wrong
         unidocGenjavadocVersion // verify if this needs to be here or our configuration is wrong
       ),
-      coverageExcludedFiles :=
-        ".*/AgentPekkoSerializer;.*/AgentWiring;.*/AgentApp;.*/ProcessExecutor;.*/GatewayMain;.*/SequenceManagerApp;.*/SimulationScript;.*/SequencerWiring;.*/SequenceComponentWiring;.*/SequencerApp;.*/EswCommand;.*/Keycloak;.*/AgentServiceApp;.*/BuildInfo;.*/.*Codecs;.*/AgentCliCommand;.*/AgentServiceApi;.*/ComponentNotFoundException;.*/ContainerConfig;.*/EitherExt;.*/EitherOps;.*/Failed;.*/EventApi;.*/StartOptions;.*/StartOptions;.*/ScriptError;.*/UnhandledCommandException;.*/ProvisionVersionFailure;.*/SequenceManagerResponses;.*/Timeouts;.*/ProcessUtils;.*/HostConfig"
+//      coverageExcludedFiles :=
+//        ".*/AgentPekkoSerializer;.*/AgentWiring;.*/AgentApp;.*/ProcessExecutor;.*/GatewayMain;.*/SequenceManagerApp;.*/SimulationScript;.*/SequencerWiring;.*/SequenceComponentWiring;.*/SequencerApp;.*/EswCommand;.*/Keycloak;.*/AgentServiceApp;.*/BuildInfo;.*/.*Codecs;.*/AgentCliCommand;.*/AgentServiceApi;.*/ComponentNotFoundException;.*/EitherExt;.*/EitherOps;.*/Failed;.*/EventApi;.*/StartOptions;.*/ScriptError;.*/UnhandledCommandException"
+      coverageExcludedFiles := ".*/.*Codecs"
     )
 }