Skip to content

Issue with Time Signature  #5

@Balthov60

Description

@Balthov60

Hi !
For some reason you transform the denominator of time signature to it's log2 value
But when you compute the user friendly time signature you don't revert the denominator correctly, you compute pow($logDenominator, 2) instead of pow(2, $logDenominator)

// Constructor
parent::__construct(array($numerator, log($denominator, 2), $metronomePulse, $thirtySecondNotesPerQuarterNote));

// Time signature computation
public static function getTimeSignature($numerator, $logarithmicDenominator) {
	return $numerator . '/' . pow($logarithmicDenominator, 2);
}

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions