fix: ruff format violations in 6 files

Author: tmcarmichael

src/brain/scoring_phases.py

@@ -45,6 +45,50 @@ def _apply_modifiers(score: float, phase: str, rule_name: str, goap_hint: str) -
     return score
 
 
+def _is_rule_blocked(
+    brain: Brain,
+    r: RuleDef,
+    now: float,
+    rule_eval: dict,
+    diag_results: list,
+    rule_times: dict,
+) -> bool:
+    """Check cooldown and circuit breaker. Returns True if rule should be skipped.
+
+    Shared by Phases 2/3/4 to avoid duplicating eligibility logic.
+    """
+    if r.name in brain._cooldowns and now < brain._cooldowns[r.name]:
+        remaining = brain._cooldowns[r.name] - now
+        rule_eval[r.name] = f"cooldown({remaining:.0f}s)"
+        diag_results.append(f"{r.name}=CD")
+        rule_times[r.name] = 0.0
+        return True
+    breaker = brain._breakers.get(r.name)
+    if breaker and not breaker.allow():
+        rule_eval[r.name] = "OPEN"
+        diag_results.append(f"{r.name}=OPEN")
+        rule_times[r.name] = 0.0
+        return True
+    return False
+
+
+def _safe_score(fn: object, *args: object) -> float:
+    """Call a scoring function, returning 0.0 on any exception.
+
+    Logs at WARNING so failures are visible but don't crash the tick.
+    """
+    try:
+        result: float = fn(*args)  # type: ignore[operator]
+        return result
+    except Exception:
+        log.warning(
+            "[DECISION] Score function %s raised, defaulting to 0.0",
+            getattr(fn, "__name__", fn),
+            exc_info=True,
+        )
+        return 0.0
+
+
 def compute_divergence(brain: Brain, state: GameState, now: float, binary_winner: str) -> None:
     """Phase 1: compute scores for all rules, log when score-based
     selection would differ from binary selection."""
@@ -56,10 +100,11 @@ def compute_divergence(brain: Brain, state: GameState, now: float, binary_winner
         if r.name in brain._cooldowns and now < brain._cooldowns[r.name]:
             scores[r.name] = -1.0  # on cooldown
             continue
-        try:
-            s = r.score_fn(state)
-        except Exception:
-            s = 0.0
+        breaker = brain._breakers.get(r.name)
+        if breaker and not breaker.allow():
+            scores[r.name] = -2.0  # circuit-broken
+            continue
+        s = _safe_score(r.score_fn, state)
         scores[r.name] = s
         if s > best_score:
             best_score = s
@@ -89,11 +134,7 @@ def select_by_tier(
     tier_groups: dict[int, list[RuleDef]] = defaultdict(list)
 
     for r in brain._rules:
-        if r.name in brain._cooldowns and now < brain._cooldowns[r.name]:
-            remaining = brain._cooldowns[r.name] - now
-            rule_eval[r.name] = f"cooldown({remaining:.0f}s)"
-            diag_results.append(f"{r.name}=CD")
-            rule_times[r.name] = 0.0
+        if _is_rule_blocked(brain, r, now, rule_eval, diag_results, rule_times):
             continue
         tier_groups[r.tier].append(r)
 
@@ -103,7 +144,7 @@ def select_by_tier(
         scored: list[tuple[float, RuleDef]] = []
         for r in tier_groups[tier]:
             t0 = time.perf_counter()
-            s = _apply_modifiers(r.score_fn(state), phase, r.name, goap_hint)
+            s = _apply_modifiers(_safe_score(r.score_fn, state), phase, r.name, goap_hint)
             rule_times[r.name] = (time.perf_counter() - t0) * 1000
             rule_eval[r.name] = f"{s:.2f}" if s > 0 else "0"
             diag_results.append(f"{r.name}={s:.2f}")
@@ -128,14 +169,10 @@ def select_weighted(
     phase, goap_hint = _resolve_phase_context(brain)
 
     for r in brain._rules:
-        if r.name in brain._cooldowns and now < brain._cooldowns[r.name]:
-            remaining = brain._cooldowns[r.name] - now
-            rule_eval[r.name] = f"cooldown({remaining:.0f}s)"
-            diag_results.append(f"{r.name}=CD")
-            rule_times[r.name] = 0.0
+        if _is_rule_blocked(brain, r, now, rule_eval, diag_results, rule_times):
             continue
         t0 = time.perf_counter()
-        s = _apply_modifiers(r.score_fn(state), phase, r.name, goap_hint)
+        s = _apply_modifiers(_safe_score(r.score_fn, state), phase, r.name, goap_hint)
         rule_times[r.name] = (time.perf_counter() - t0) * 1000
         weighted = r.weight * s
         rule_eval[r.name] = f"{weighted:.1f}" if s > 0 else "0"
@@ -173,18 +210,14 @@ def select_with_considerations(
     phase, goap_hint = _resolve_phase_context(brain)
 
     for r in brain._rules:
-        if r.name in brain._cooldowns and now < brain._cooldowns[r.name]:
-            remaining = brain._cooldowns[r.name] - now
-            rule_eval[r.name] = f"cooldown({remaining:.0f}s)"
-            diag_results.append(f"{r.name}=CD")
-            rule_times[r.name] = 0.0
+        if _is_rule_blocked(brain, r, now, rule_eval, diag_results, rule_times):
             continue
         t0 = time.perf_counter()
         # Phase 4: prefer considerations over score_fn when defined
         if r.considerations and brain._ctx:
-            raw = score_from_considerations(r.considerations, state, brain._ctx)
+            raw = _safe_score(score_from_considerations, r.considerations, state, brain._ctx)
         else:
-            raw = r.score_fn(state)
+            raw = _safe_score(r.score_fn, state)
         s = _apply_modifiers(raw, phase, r.name, goap_hint)
         rule_times[r.name] = (time.perf_counter() - t0) * 1000
         weighted = r.weight * s