false positive with a Body being replaced by a NopCloser

[ccoVeille]

Please consider the following code

package a

import (
	"bytes"
	"io"
	"net/http"
)

func readNoOp(url string) (*http.Response, error) {
	r, err := http.DefaultClient.Get(url)
	if err != nil {
		return r, err
	}

	raw, err := io.ReadAll(r.Body)
	if err != nil {
		return r, err
	}
	r.Body.Close()

	r.Body = io.NopCloser(bytes.NewReader(raw))

	return r, nil
}

func issuenop(url string) error {
	r, err := readNoOp(url) # body close will report an issue here
	if err != nil {
		return err
	}

	_ = r
	return nil
}

[ccoVeille]

I reported the minimal code to reproduce it.
I'm facing the code with package we use to make http calls.
The code is way larger, we have methods for posting JSON, getting HTML, etc ...
Closing the body in the wrapper was the solution we found to avoid doing such a thing.

A solution I'm looking is either:

• bodyclose detects the io.NopCloser
• bodyclose is updated to add an exclusion list

Please note, I also have code that are not using our wrapper, and these are the ones I would like to have bodyclose detection.

Thanks