Hard to differentiate logging from what's happening

[PeterGerrard]

In the server main file it is sometimes hard to differentiate logs from logic:

Example:

    const gameID = newPlayer.gameID;
    if (debug>=3) console.log(`Player ${newPlayer.name} (${newID}) initially voted for ${newPlayer.vote}`);
    const players = Players.find({ gameID: gameID, session: {$ne: null}, alive: true }, { fields: {name:1, vote:1} }).fetch();
    if (players.some (p => !p.vote)) return null;
    const game = Games.findOne(gameID);
    if (debug>=1) {
      console.log(`Game ${game.name} ${game.state}: all ${players.length} players voted`);
      for (const player of players) {
        if (player.vote == "0") {
          console.log(`  Player ${player.name} (${player._id}) did not vote (${player.vote})`);
        } else {
          const vote = players.find (p => p._id === player.vote);
          if (vote)
            console.log(`  Player ${player.name} (${player._id}) voted for ${vote.name} (${player.vote})`);
          else
            console.log(`  Player ${player.name} (${player._id}) invalid vote for ${player.vote}`);
        }
      }
    }
    if (game.state == "nightTime") {
      dawn (game, players);
      Players.update({gameID: gameID, session: {$ne: null}}, {$set: {vote: null}}, {multi: true});
    }

From: https://github.com/timadye/werewolf/blob/master/server/main.js#L107-L133

The interesting code is:

    const gameID = newPlayer.gameID;
    const players = Players.find({ gameID: gameID, session: {$ne: null}, alive: true }, { fields: {name:1, vote:1} }).fetch();
    if (players.some (p => !p.vote)) return null;
    const game = Games.findOne(gameID);
    if (game.state == "nightTime") {
      dawn (game, players);
      Players.update({gameID: gameID, session: {$ne: null}}, {$set: {vote: null}}, {multi: true});
    }

Some potential changes:

• Extract Things like LogDebug, LogInfo which have the debug if checks included
• For larger logs things extract entire methods for them e.g.

function logVotesResult(game, players) {
// omitted for brevity
}

[timadye]

yeah, everything debug>=2 is left over from debugging the code. I prefer not to remove that while I'm still developing.
debug=1 is on by default, and useful to see what's going on in normal game play. That would be nice to split out for anything non-trivial, as you suggest.
Rather than write a LogDebug function, would it be better to use a proper tool? Also all go to console.log, rather than using JS's different levels. So if I was being less half-arsed about this, I'd rationalise it all. But TBH, if(debug>=2) is quick and simple.