Skip to content

Commit 89958fc

Browse files
authored
Merge pull request #119 from ticktackk/develop
1.4.1
2 parents 5055089 + a1b129a commit 89958fc

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
CHANGELOG
22
==========================
33

4+
## 1.4.1 (`1040170`)
5+
6+
- **Fix:** Command `tck-devtools:create-entity-from-table` marks auto increment primary key as required (#118)
7+
48
## 1.4.0 (`1040070`)
59

610
- **New:** A new CLI command which will add class properties to entities similar to stock installation but with slight tweaks (#116)

Cli/Command/EntityFromTable.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,12 @@ protected function execute(InputInterface $input, OutputInterface $output) : int
208208
$fieldData['required'] = var_export(true, true);
209209
}
210210

211+
// Single column primary key and auto increment so this needs to marked as not required
212+
if (!is_array($primaryKey) && array_key_exists('autoIncrement', $fieldData))
213+
{
214+
unset($fieldData['required']);
215+
}
216+
211217
$definition = [];
212218
foreach ($fieldData AS $key => $value)
213219
{

addon.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
"legacy_addon_id": "",
33
"title": "Developer Tools",
44
"description": "This add-on provides enhancements for add-on developers.",
5-
"version_id": 1040070,
6-
"version_string": "1.4.0",
5+
"version_id": 1040170,
6+
"version_string": "1.4.1",
77
"dev": "TickTackk",
88
"dev_url": "https://xenforo.com/community/members/90375/",
99
"faq_url": "",

0 commit comments

Comments
 (0)