`TUnit0023` for a member that is being disposed

[alexeyzimarev]

Maybe it's something I don't understand about the dependencies lifecycle, but I get TUnit0023 warning from the analyser for something that is getting disposed:

If there's something I need to change, and it's reasonable, I'd be happy to submit a PR to update the docs.

[thomhurst]

Looks like a bug with the analyzer - your code looks correct 😄

[alexeyzimarev]

Yeah that's what I thought. Like I mentioned, it's not just class setup/dispose, but also per-test:

Cleanup:

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[thomhurst]

Sorry for the late reply. I can't seem to replicate this. Are you still having this issue?

[alexeyzimarev]

Yeah I do. Did some work today to upgrade to the latest TUnit version and the issue is still there. The code is OSS, so the simplest repro is to go here Eventuous/eventuous#453, clone, find TUnit0023 pragmas. As soon as any of those are removed, the warning comes up. Same with the build, it produces warnings.

[thomhurst]

Aha - TUnit analyzer is actually doing its job!

You new up a static field using Before(Class) and dispose it in After(Class) - This is good.

But then in your test constructor (which will be hit for every test in that class) - You overwrite the static field with a new value. And the old one would never be disposed, and we've now lost the reference to it.

Eventuous/eventuous#454

[alexeyzimarev]

I have still one place left and it doesn't look like the one you fixed (thank you).

It's in the SubscriptionSpec class, where there are two fields:

    RabbitMqSubscription               _subscription = null!;
    TestEventListener                  _es           = null!;

both being instantiated in:

    [Before(Test)]
    public async ValueTask InitializeAsync() {
        _es       = new();
        _handler  = new();
        _producer = new(_fixture.ConnectionFactory);

        var queue = Guid.NewGuid().ToString();

        _subscription = new(
            _fixture.ConnectionFactory,
            new RabbitMqSubscriptionOptions {
                ConcurrencyLimit = 10,
                SubscriptionId   = queue,
                Exchange         = _exchange,
                ThrowOnError     = true
            },
            new ConsumePipe().AddDefaultConsumer(_handler),
            _loggerFactory
        );
        await _subscription.SubscribeWithLog(_log);
        await _producer.StartAsync();
    }

and disposed:

    [After(Test)]
    public async ValueTask DisposeAsync() {
        await _producer.StopAsync();
        await _subscription.UnsubscribeWithLog(_log);
        _es.Dispose();
        await _subscription.DisposeAsync();
    }

I still get the same warning. Following up your fix, I checked if those fields are mutated elsewhere, but it's not the case...