From 516d676bdcd897386043921cad89e8549d510560 Mon Sep 17 00:00:00 2001 From: Thomas Beaujean Date: Thu, 22 Jan 2026 09:19:45 +0100 Subject: [PATCH 1/2] Type return for the findBy methods --- src/Resources/views/Generator/ColumnTemplate.html.twig | 3 +++ tests/Repository/MyClassRepositoryBase.php | 9 +++++++++ tests/Service/ExpectedMyClassRepositoryBase.txt | 9 +++++++++ 3 files changed, 21 insertions(+) diff --git a/src/Resources/views/Generator/ColumnTemplate.html.twig b/src/Resources/views/Generator/ColumnTemplate.html.twig index 4949a5d..1e9a2d4 100644 --- a/src/Resources/views/Generator/ColumnTemplate.html.twig +++ b/src/Resources/views/Generator/ColumnTemplate.html.twig @@ -56,6 +56,9 @@ return $qb; } + /** + * @return \{{entityClasspath}}[] + */ public function findBy{{ column }}( mixed $value, $operator = Comparison::EQ, diff --git a/tests/Repository/MyClassRepositoryBase.php b/tests/Repository/MyClassRepositoryBase.php index 38c02dd..9315407 100644 --- a/tests/Repository/MyClassRepositoryBase.php +++ b/tests/Repository/MyClassRepositoryBase.php @@ -417,6 +417,9 @@ public static function filterNotInId( return $qb; } + /** + * @return \Tbn\QueryBuilderRepositoryGeneratorBundle\Tests\Entity\MyClass[] + */ public function findById( mixed $value, $operator = Comparison::EQ, @@ -566,6 +569,9 @@ public static function filterNotInNumber( return $qb; } + /** + * @return \Tbn\QueryBuilderRepositoryGeneratorBundle\Tests\Entity\MyClass[] + */ public function findByNumber( mixed $value, $operator = Comparison::EQ, @@ -715,6 +721,9 @@ public static function filterNotInName( return $qb; } + /** + * @return \Tbn\QueryBuilderRepositoryGeneratorBundle\Tests\Entity\MyClass[] + */ public function findByName( mixed $value, $operator = Comparison::EQ, diff --git a/tests/Service/ExpectedMyClassRepositoryBase.txt b/tests/Service/ExpectedMyClassRepositoryBase.txt index 38c02dd..9315407 100644 --- a/tests/Service/ExpectedMyClassRepositoryBase.txt +++ b/tests/Service/ExpectedMyClassRepositoryBase.txt @@ -417,6 +417,9 @@ class MyClassRepositoryBase extends \Doctrine\Bundle\DoctrineBundle\Repository\S return $qb; } + /** + * @return \Tbn\QueryBuilderRepositoryGeneratorBundle\Tests\Entity\MyClass[] + */ public function findById( mixed $value, $operator = Comparison::EQ, @@ -566,6 +569,9 @@ class MyClassRepositoryBase extends \Doctrine\Bundle\DoctrineBundle\Repository\S return $qb; } + /** + * @return \Tbn\QueryBuilderRepositoryGeneratorBundle\Tests\Entity\MyClass[] + */ public function findByNumber( mixed $value, $operator = Comparison::EQ, @@ -715,6 +721,9 @@ class MyClassRepositoryBase extends \Doctrine\Bundle\DoctrineBundle\Repository\S return $qb; } + /** + * @return \Tbn\QueryBuilderRepositoryGeneratorBundle\Tests\Entity\MyClass[] + */ public function findByName( mixed $value, $operator = Comparison::EQ, From 9230b7086ff5a711635cd0e9ddab4d470ea89805 Mon Sep 17 00:00:00 2001 From: Thomas Beaujean Date: Thu, 22 Jan 2026 09:20:02 +0100 Subject: [PATCH 2/2] makefile: remove ssh sock --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 545ca51..cf74392 100644 --- a/Makefile +++ b/Makefile @@ -5,10 +5,10 @@ help: @grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}' composer-install: ## composer install - docker run --rm -it -w="/srv/app" --volume $$(pwd)/.config/composer:/root/.config/composer --volume $${SSH_AUTH_SOCK}:/ssh-agent --env SSH_AUTH_SOCK=/ssh-agent --volume $$(pwd):/srv/app composer:2.9.2 install + docker run --rm -it -w="/srv/app" --volume $$(pwd)/.config/composer:/root/.config/composer --volume $$(pwd):/srv/app composer:2.9.2 install composer-update: ## composer update - docker run --rm -it -w="/srv/app" --volume $$(pwd)/.config/composer:/root/.config/composer --volume $${SSH_AUTH_SOCK}:/ssh-agent --env SSH_AUTH_SOCK=/ssh-agent --volume $$(pwd):/srv/app composer:2.9.2 update + docker run --rm -it -w="/srv/app" --volume $$(pwd)/.config/composer:/root/.config/composer --volume $$(pwd):/srv/app composer:2.9.2 update phpunit: ## phpunit - docker run --rm -it -w="/srv/app" --volume $$(pwd)/.config/composer:/root/.config/composer --volume $${SSH_AUTH_SOCK}:/ssh-agent --env SSH_AUTH_SOCK=/ssh-agent --volume $$(pwd):/srv/app --entrypoint="" composer:2.9.2 vendor/bin/phpunit + docker run --rm -it -w="/srv/app" --volume $$(pwd)/.config/composer:/root/.config/composer --volume $$(pwd):/srv/app --entrypoint="" composer:2.9.2 vendor/bin/phpunit