Methods not retrieving correctly for hosted checkout option

[x97wehner]

Since the update to the new Stripe API for this module in version 1.8, my hosted checkout page has not reflected all available options that are enabled on the Stripe website dashboard. Specifically, things like Cash App and Afterpay were not showing up on the hosted checkout page anymore. I finally dug into it a bit on StripeApi.php and by commenting out the default code that sets type if no methods are returned, the page now operates correctly. It seems there is a problem in retrieving methods from stripe correctly.

This is all I changed to get this functioning as it is supposed to (The commented out part):

public function createCheckoutSession(
        Cart $cart,
        string $methodId,
        array $methods = [],
        array $paymentMethodOptions = []
    ) {
        $context = Context::getContext();
        $total = Utils::getCartTotal($cart);
        $validationLink = Utils::getValidationUrl($methodId);
    /*    if (! $methods) {
            $methods = [
                \Stripe\PaymentMethod::TYPE_CARD, 
            ];
        }*/

[getdatakick]

Then only method that does not provide $methods parameter is CheckoutMethod. There is some confusion about what this method is. The CTA texts suggests that this method should be 'Pay by card' method , so the restriction should indeed be applied.

You would like this method to work as a 'All configured stripe methods' payment methods. Which is understandable, but not everyone want that.

I suggest we split this method to two different one -- one new method for 'Pay by card' only (this would restrict methods), and one without restriction.

[x97wehner]

I was reading their information as well and it does read a little confusing. They have the language around elements different from custom integrations. But yes, in general, for the hosted checkout, we shouldn't need to set a payment method and then the hosted checkout will align with all options the stripe account has enabled. If we want to have a dedicated card only hosted checkout page, it would need a separate method.