Use github actions to check clean jupyter notebook runs before merging

[MrMinos]

https://github.com/mcullan/jupyter-actions

[MrMinos]

Rebased my branch and pushed. The github action should run, and succeed.

[MrMinos]

RuntimeError: trim failed:
 final_simplex: (array([[-0.00398416, -0.0198497 ],
       [-0.00397723, -0.01982051],
       [-0.00397813, -0.01978912]]), array([0.00103052, 0.00103478, 0.00109464]))
           fun: 0.0010305168236236018
       message: 'Optimization terminated successfully.'
          nfev: 78
           nit: 41
        status: 0
       success: True

Huh, success == True, but still RuntimeError

[Rio6]

           fun: 0.0010305168236236018

ftol is 1e-3 and that number is bigger

[MrMinos]

Good catch. I've had the local copy set to ftol=1e-1, in the notebook.

[MrMinos]

Looks like this is done! Thank you for working on it.

[MrMinos]

Actually @Rio6, one request. It seems like even on the branches, the github action is running on the master. Would it be possible to run it on the merge request's base branch?

[Rio6]

oh hm, let me look

[Rio6]

pushed a commit to #14, did it change anything?

[MrMinos]

It still seems to be running master. That branch's ftol is 0.1.

[Rio6]

it's still 1e-3 for https://github.com/theprojectboom/engine/blob/minos-waveripper-v1/scripts/trim.ipynb

[MrMinos]

Ohh, of course. It's checking for all notebooks. Could you make a separate quick PR and merge to master?

I'll revert the PR and pull the change from master.

[Rio6]

#17