From 777a3565b59d793588365e2cdd2de88ee7969fbf Mon Sep 17 00:00:00 2001 From: sturmianseq <88301801+sturmianseq@users.noreply.github.com> Date: Tue, 16 Nov 2021 00:29:29 +0800 Subject: [PATCH 1/2] Fix a flaky test by cleaning a polluted state. --- tests/test_model.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test_model.py b/tests/test_model.py index 1fa937e..27a8cb0 100644 --- a/tests/test_model.py +++ b/tests/test_model.py @@ -526,6 +526,7 @@ def test_validate_multiplicity(self): self.assertEqual(who.born, [b1, b2]) def test_not_multiple_instance(self): + model.factory.auto_id_type = 'int-per-segment' who = model.Person() n = model.Name(content="Test") who.identified_by = n From 64b1fc0d7246ca2122fcb42ddacc8d207f8f9515 Mon Sep 17 00:00:00 2001 From: sturmianseq <88301801+sturmianseq@users.noreply.github.com> Date: Tue, 16 Nov 2021 00:49:38 +0800 Subject: [PATCH 2/2] Clean pollution to avoid flaky tests. --- tests/test_model.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_model.py b/tests/test_model.py index 27a8cb0..6d00b6e 100644 --- a/tests/test_model.py +++ b/tests/test_model.py @@ -280,6 +280,7 @@ def test_bad_autoid(self): model.factory.auto_id_type = "broken" self.assertRaises(model.ConfigurationError, model.factory.generate_id, "irrelevant") + model.factory.auto_id_type = 'int-per-segment' def test_int(self): model.factory.auto_assign_id = True @@ -526,7 +527,6 @@ def test_validate_multiplicity(self): self.assertEqual(who.born, [b1, b2]) def test_not_multiple_instance(self): - model.factory.auto_id_type = 'int-per-segment' who = model.Person() n = model.Name(content="Test") who.identified_by = n