Unexpected behaviour of periodic_phi

[jmontejo]

Hi,
I'm seeing a very unexpected behaviour when testing periodic_phi. First, it seems to propagate also to wasserstein, and second it seems to stay and can't be undone setting periodic_phi=False.
Am I doing something wrong here is this a bug?

Cheers
Javier

[pkomiske]

Hi Javier,

Thanks for sharing this. What I suspect is happening here is that in the first cell, periodic_phi is False and this is the correct value for this computation. Then in the next cell you turn it on so the value decreases some. But, problematically, I suspect this cell is modifying your events so that when you run the third cell, the events are actually different than in the first one. Can you check if this is the case?

Obviously, this behavior is not desired (if it's what I think it is) so I will try to get a bug fix in. It's harder these days as physics is no longer my day job. For now I think you could ensure that you don't use an array after passing it in to these functions.

Oh and one more thing, can you tell me your Wasserstein version (and if it's not the latest one, update and try this again)? I fixed an issue like this in there at some point but am not sure if it's propagated out yet.

Patrick

[jmontejo]

Hi Patrick,
I updated Wasserstein to the last version and I still see the same effect. I can confirm that calling with periodic_phi = True changes the event, so that's the culprit.

Cheers, Javier