Directory creation upon calling extractall()

[dubsjw]

Calling "extractall" on a zip file doesn't create folders which exist in the archive, therefore not extracting file that exist within those folders. I would guess this is a limitation of fstream. For what it's worth, this was seen on Windows 7.

[AndreaSenseon]

I can confirm the function does not do what its name suggests.
Apparently does not do anything at all.

[iamOgunyinka]

I ran into this problem too but the problem is with std::fstream and not the library. std::fstream doesn't create directories, so if you have a zipped file with "internal" directories, the extractall call "fails". What I did was to call .infolist, iterate over it and manually std::filesystem::create_directories before calling extractall or you may call read directly on the miniz_cpp::zip_file object while iterating through the infolist data. Something like this:

  miniz_cpp::zip_file zip_file{ filename };
  // zip_file.extractall(); // may fail.
  auto const info_list = zip_file.infolist();
  auto const current_directory = std::filesystem::current_path();
  std::error_code ec{};

  for( auto const & info: info_list ){
    auto const p{ ( current_path / info.filename() ).parent_path() };
    if( !std::filesystem::exists( p ) ){
      std::filesystem::create_directories( p, ec );
    }
  }
  zip_file.extractall(); // most likely gonna succeed

[ray-linn]

    void extract(const zip_info &member, const std::string &path)
    {
		auto file=detail::join_path({path, member.filename});
		auto target=std::filesystem::path(file).parent_path();
        if (!std::filesystem::exists(target))
            std::filesystem::create_directories(target);
        std::fstream stream(file, std::ios::binary | std::ios::out);
        stream << open(member).rdbuf();
    }

update the extract as above