Users too frequently have to make an ARMI PR to touch Settings and Parameters #2384
Description
@keckler noted that ARMI developers too frequently have to make PRs into ARMI to deal with Settings and Parameters defined in ARMI. That is a system design problem. It seems to me the only solution here is to make sure ARMI includes fewer mandatory Settings and Parameters.
Other than that, I think the order-of-operations goes something like this:
- Review all
Settings in ARMI - Remove all unused
Settings. - If a
Settingis only used by one (internal TerraPower) project, move it out of ARMI and into that project. - Review all
Parameters in ARMI - Remove all unused
Parameters.- Removing unused TH parameters #981
- Removing unused ARMI Parameters #986
- Removing unused mech Parameters #988
- Removing unused SASSYS Parameters #989
- Removing unused Virdent parameters #990
- Removing unused Parameters #997
- Removing unused Parameters #2130
- Removing unused reactivity coeffs params #2132
- Removing unused Parameters #2134
- Removing unused TH parameters. #2136
- If a
Parameteris only used by one (internal TerraPower) project, move it out of ARMI and into that project. - Considering refactoring
XSGMandLatticePhysicsInterface, to alleviate this problem.
NOTE: Some Settings and Parameters are useful to a wide nuclear reactor audience, and we will keep them in ARMI on general principles.