Incorrect applications of consumables

[lacktheknack]

A partial re-open of #57, as the effect application glitch is still in place. Duplicate animations is fixed though!

This Alchemist's Fire consumable is set up as so:

Even setting aside that WIRE explodes if you use the last potion in the stack (because it can't find the delayed effects, I presume), this is supposed to be a throwable potion at a target that's not the holder.

However, despite me never asking the effect to apply to the carrier, the effect transfers to the carrying token when:
-any details of the potion are adjusted
-the number of potions held is changed
-the potion is used
-the target uses the Use An Action option to end the effect on itself

The carrier is bursting constantly into flame, and this only seems to be happening with consumables. It also happens to ammunition that applies an effect if used directly - the wielder gets the transferred effect repeatedly. I suppose I could change the Alchemist's Fire to a weapon, but I would rather have consumables behave properly.

[lacktheknack]

Actually, now that I'm playing around, this is happening to ALL my items, including features and spells. For example, I tried adjusting the details on a monster's ranged attack with an effect, and the instant I did, the effect immediately applied to the monster on the canvas. Something very fishy is happening.

[teroparvinen]

Items and features set transfer on for their effects by default, and I think this might be the issue here. I'm not exactly sure what causes this, might have been a dnd5e 2.1/2.2 addition. Transfer is the technical term for the "Apply Effect to Actor" option on an active effect. WIRE does not apply effects that have this option selected to the target of an item activation, but the system applies the effect on the user/caster.

If this is the issue, you can also remove the "This attack hits" condition on the item and just have the fire effect be immediate.

Let me know if this solves it.