Fix duplicate key risks in Svelte each blocks#3208
Open
Alex-Tideman wants to merge 3 commits intocodefreeze-03.02.26from
Open
Fix duplicate key risks in Svelte each blocks#3208Alex-Tideman wants to merge 3 commits intocodefreeze-03.02.26from
Alex-Tideman wants to merge 3 commits intocodefreeze-03.02.26from
Conversation
High risk fixes: - workflow-callback: change || to ?? so falsy eventId/requestId values don't skip to index fallback - combobox: add (v) key to multiselect chip rendering - schedule-recent-runs: prefix index fallback with _ to prevent collisions with real workflow/run IDs Medium risk fixes: - Add stable id field to SearchAttributeFilter type with generateFilterId() factory, replacing fragile attribute-index composite keys in filter-list, dropdown-filter-list (workflow and activity variants) - Drop redundant index from column keys in orderable-list and event-summary-table where labels are already unique - Update all SearchAttributeFilter construction sites to include id - Update tests to use toMatchObject for filter assertions
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| </Link> | ||
| </div> | ||
| {#each sortRecentRuns(recentRuns) as run, i (`${run?.startWorkflowResult?.workflowId ?? i}:${run?.startWorkflowResult?.runId ?? i + 1}`)} | ||
| {#each sortRecentRuns(recentRuns) as run, i (`${run?.startWorkflowResult?.workflowId ?? `_${i}`}:${run?.startWorkflowResult?.runId ?? `_${i}`}`)} |
Contributor
There was a problem hiding this comment.
⚠️ 'run.startWorkflowResult' is possibly 'null' or 'undefined'.⚠️ 'run.startWorkflowResult' is possibly 'null' or 'undefined'.⚠️ Argument of type 'string | null | undefined' is not assignable to parameter of type 'string'.⚠️ Type 'string | null | undefined' is not assignable to type 'string | undefined'.
Contributor
|
Detailed explanation of every each block key change, the specific problem each fix addresses, and which items were reviewed and intentionally left unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High risk fixes:
Medium risk fixes:
Description & motivation 💭
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?