From 3ebb018cc4e4b66b1ff738d3accacccb28b89e40 Mon Sep 17 00:00:00 2001 From: rodrigozhou Date: Fri, 21 Feb 2025 16:25:17 -0800 Subject: [PATCH 1/2] [GHA] Fix token to trigger publish workflow --- .github/workflows/trigger-publish.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/trigger-publish.yml b/.github/workflows/trigger-publish.yml index 4aa6d09..06a35ac 100644 --- a/.github/workflows/trigger-publish.yml +++ b/.github/workflows/trigger-publish.yml @@ -16,6 +16,13 @@ jobs: shell: bash steps: + - name: Generate a token + id: generate_token + uses: tibdex/github-app-token@b62528385c34dbc9f38e5f4225ac829252d1ea92 + with: + app_id: ${{ secrets.TEMPORAL_CICD_APP_ID }} + private_key: ${{ secrets.TEMPORAL_CICD_PRIVATE_KEY }} + - name: Get git branch name id: get_branch run: | @@ -23,7 +30,7 @@ jobs: - name: Dispatch docker builds Github Action env: - PAT: ${{ secrets.COMMANDER_DATA_TOKEN }} + PAT: ${{ steps.generate_token.outputs.token }} PARENT_REPO: temporalio/docker-builds PARENT_BRANCH: ${{ toJSON('main') }} WORKFLOW_ID: update-submodules.yml From 8b86aeb939cc1bd51e8cd7e3a1eab46addec9b91 Mon Sep 17 00:00:00 2001 From: rodrigozhou Date: Mon, 24 Feb 2025 10:01:42 -0800 Subject: [PATCH 2/2] address comments --- .github/workflows/trigger-publish.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/trigger-publish.yml b/.github/workflows/trigger-publish.yml index 06a35ac..1448274 100644 --- a/.github/workflows/trigger-publish.yml +++ b/.github/workflows/trigger-publish.yml @@ -16,12 +16,13 @@ jobs: shell: bash steps: - - name: Generate a token + - name: Generate token id: generate_token - uses: tibdex/github-app-token@b62528385c34dbc9f38e5f4225ac829252d1ea92 + uses: actions/create-github-app-token@v1 with: - app_id: ${{ secrets.TEMPORAL_CICD_APP_ID }} - private_key: ${{ secrets.TEMPORAL_CICD_PRIVATE_KEY }} + app-id: ${{ secrets.TEMPORAL_CICD_APP_ID }} + private-key: ${{ secrets.TEMPORAL_CICD_PRIVATE_KEY }} + owner: ${{ github.repository_owner }} - name: Get git branch name id: get_branch