From 18c74d53995b172e9d338975109b8720e0cc0ab4 Mon Sep 17 00:00:00 2001 From: Alex Mazzeo Date: Tue, 10 Feb 2026 10:27:43 -0800 Subject: [PATCH] reserve field tag 7 in temporal.api.workflowservice.v1.PollWorkflowTaskQueueRequest and temporal.api.workflowservice.v1.PollActivityTaskQueueRequest. Move worker_instance_key to tag 8 in those messages. Add buf ignore to allow the name worker_instance_key to be retagged. --- buf.yaml | 2 ++ .../api/workflowservice/v1/request_response.proto | 12 ++++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/buf.yaml b/buf.yaml index 51534eb8f..7a8f9df36 100644 --- a/buf.yaml +++ b/buf.yaml @@ -16,6 +16,8 @@ breaking: - temporal/api/enums/v1/failed_cause.proto # TODO: remove this once the changes with WorkflowExecutionExtendedInfo.pause_info is merged - temporal/api/workflow/v1/message.proto + # TODO (amazzeo): remove this once worker_instance_key has successfully been retagged in PollWorkflowTaskQueueRequest and PollActivityTaskQueueRequest + - temporal/api/workflowservice/v1/request_response.proto lint: use: - DEFAULT diff --git a/temporal/api/workflowservice/v1/request_response.proto b/temporal/api/workflowservice/v1/request_response.proto index d6658dd2b..4bf3272c6 100644 --- a/temporal/api/workflowservice/v1/request_response.proto +++ b/temporal/api/workflowservice/v1/request_response.proto @@ -261,7 +261,7 @@ message PollWorkflowTaskQueueRequest { string identity = 3; // A unique key for this worker instance, used for tracking worker lifecycle. // This is guaranteed to be unique, whereas identity is not guaranteed to be unique. - string worker_instance_key = 7; + string worker_instance_key = 8; // Deprecated. Use deployment_options instead. // Each worker process should provide an ID unique to the specific set of code it is running // "checksum" in this field name isn't very accurate, it should be though of as an id. @@ -273,6 +273,10 @@ message PollWorkflowTaskQueueRequest { // Worker deployment options that user has set in the worker. // Experimental. Worker Deployments are experimental and might significantly change in the future. temporal.api.deployment.v1.WorkerDeploymentOptions deployment_options = 6; + + // Removed in 1.55.0; was temporal.api.worker.v1.WorkerHeartbeat worker_heartbeat + reserved 7; + reserved "worker_heartbeat"; } message PollWorkflowTaskQueueResponse { @@ -439,7 +443,7 @@ message PollActivityTaskQueueRequest { string identity = 3; // A unique key for this worker instance, used for tracking worker lifecycle. // This is guaranteed to be unique, whereas identity is not guaranteed to be unique. - string worker_instance_key = 7; + string worker_instance_key = 8; temporal.api.taskqueue.v1.TaskQueueMetadata task_queue_metadata = 4; // Information about this worker's build identifier and if it is choosing to use the versioning // feature. See the `WorkerVersionCapabilities` docstring for more. @@ -447,6 +451,10 @@ message PollActivityTaskQueueRequest { temporal.api.common.v1.WorkerVersionCapabilities worker_version_capabilities = 5 [deprecated = true]; // Worker deployment options that user has set in the worker. temporal.api.deployment.v1.WorkerDeploymentOptions deployment_options = 6; + + // Removed in 1.55.0; was temporal.api.worker.v1.WorkerHeartbeat worker_heartbeat + reserved 7; + reserved "worker_heartbeat"; } message PollActivityTaskQueueResponse {