Windows: running GenROSIDL.sh results in code folder from other (non-TempoROS) game plugins being removed

[Panics]

My project folder has a custom game plugin that integrates paho mqtt.
This custom game plugin has a module named 'mqtt' that exposes the following public files:

Public/mqtt/async_client.h
Public/mqtt/buffer_ref.h
Public/mqtt/buffer_view.h
Public/mqtt/callback.h
Public/mqtt/client.h
Public/mqtt/connect_options.h
Public/mqtt/create_options.h
Public/mqtt/delivery_token.h
Public/mqtt/disconnect_options.h
Public/mqtt/exception.h
Public/mqtt/export.h
Public/mqtt/iaction_listener.h
Public/mqtt/iasync_client.h
Public/mqtt/iclient_persistence.h
Public/mqtt/message.h
Public/mqtt/platform.h
Public/mqtt/properties.h
Public/mqtt/response_options.h
Public/mqtt/server_response.h
Public/mqtt/ssl_options.h
Public/mqtt/string_collection.h
Public/mqtt/subscribe_options.h
Public/mqtt/thread_queue.h
Public/mqtt/token.h
Public/mqtt/topic.h
Public/mqtt/topic_matcher.h
Public/mqtt/types.h
Public/mqtt/will_options.h

When GenROSIDL.sh runs, the parent folder Public/mqtt gets falsely marked for deletion in the function GEN_MODULE_MSG_AND_SRVS() at line 228

 # Remove any generated files that were not refreshed this time.
  if [ -d "$PUBLIC_DEST_DIR/$PACKAGE_NAME" ]; then
    for FILE in $(find "$PUBLIC_DEST_DIR/$PACKAGE_NAME" -type f); do
      if [[ ! $REFRESHED_FILES =~ $FILE ]]; then
        rm "$FILE"
      fi
    done
  fi

Needless to say, this should not happen.

This is because the folder name mqtt equals the package name mqtt, which satisfies if [ -d "$PUBLIC_DEST_DIR/$PACKAGE_NAME" ]; then. A quick workaround is to rename Public/mqtt to Public/paho-mqtt to avoid this. A proper fix would be to update the GenROSIDL.sh code to not be too agressive when determining which files/folders to delete

[Panics]

If the above issue is caused by TempoROS generating files and placing them in the folder Public/<ModuleName> then perhaps a quick fix could be if Tempo uses a prefix/postfix for the foldername - so something like Public/<ModuleName>_TempoGen. This makes it also clear to the developer that the files in that folder are automatically generated

[pete-tempo]

@Panics thanks for reporting this. The problem is that ModuleName/Public/module_name is not a typical module structure. I assumed that the snake_case module name would always be a safe choice for the ROS package name and generated code folder, and never considered this particular case. A postfix for the package name as you suggest might work, but I do think having the ROS package name match the module name is nice (for example Unreal module MyCustomSimulator gets ROS package name my_custom_simulator).

I think the best thing to do would be to only delete the folder if it has a msg or srv subfolder. That's a giveaway that it's generated ROS code. I'll find some time to do that.

In the meantime, this is a pretty specific failure case and I can think of three reasonable workarounds:

• As you said, renaming mqtt to paho-mqtt or really anything else (even MQTT is fine, I think)
• Renaming the Module containing mqtt (for example it's common to put third party code in a ThirdParty module)
• Add a ros_info.json to your module's top level (as described here) to specify a custom package name. Even if you're not using ROS in this module, this should hide your unfortunately named folder from GenROSIDL.sh

[Panics]

Thank you @pete-tempo!