master branch - compilation on linux is broken

[nopsenica]

Commit db0e6d7 (8a68587) broke compilation on linux.

[nordfalk]

Thanks for reporting this.
Can you provide some (all, actually) details on what is broken?

We are currently building without issues on CentOS for our production servers with this commit in place. @nopsenica, which distro are you using?

[nopsenica]

I have checked with ScientificLinux 6 (i.e. CentOS 6) and CentOS 7.
I will provide build output.

[nopsenica]

"git clone" followed by build attempt, the way it is specified by .spec file, fails:

build-c7:~/src# git clone https://github.com/techblue/jmagick.git
Cloning into 'jmagick'...
remote: Counting objects: 1045, done.
remote: Total 1045 (delta 0), reused 0 (delta 0), pack-reused 1045
Receiving objects: 100% (1045/1045), 1016.35 KiB | 822.00 KiB/s, done.
Resolving deltas: 100% (618/618), done.
build-c7:~/src# cd jmagick/
build-c7:~/src/jmagick# autoconf
configure.ac:381: error: possibly undefined macro: AC_DISABLE_STATIC
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:382: error: possibly undefined macro: AC_PROG_LIBTOOL

build-c7:~/src/jmagick# cat /etc/redhat-release 
CentOS Linux release 7.4.1708 (Core) 
build-c7:~/src/jmagick# 

The same thing happens on EL6 and Fedora 26.

Problem is removal of files in commit 8a68587. Without that commit, build on linux succeeds.

sudo yum install libtool

Also, I would recommend using autoreconf instead of autoconf.

autoreconf --force --install
automake --add-missing
./configure

Sorry for the confusion! Didn't realize that .spec file had outdated instructions.

Let us know if that works for your system; PR #42 updates the .spec file with these instructions.

[nopsenica]

Unfortunatelly, build is still broken:

build-c7:~/src# git clone https://github.com/techblue/jmagick.git
Cloning into 'jmagick'...
remote: Counting objects: 1099, done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 1099 (delta 1), reused 8 (delta 1), pack-reused 1089
Receiving objects: 100% (1099/1099), 1.02 MiB | 806.00 KiB/s, done.
Resolving deltas: 100% (658/658), done.
build-c7:~/src# cd jmagick/
build-c7:~/src/jmagick# autoreconf --force --install
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac and
libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree.
libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
build-c7:~/src/jmagick# automake --add-missing
configure.ac: error: no proper invocation of AM_INIT_AUTOMAKE was found.
configure.ac: You should verify that configure.ac invokes AM_INIT_AUTOMAKE,
configure.ac: that aclocal.m4 is present in the top-level directory,
configure.ac: and that aclocal.m4 was recently regenerated (using aclocal)
configure.ac:5: installing './config.guess'
configure.ac:5: installing './config.sub'
automake: error: no 'Makefile.am' found for any configure output

[nordfalk]

Try
autoreconf --force --install
automake --add-missing
./configure

@nopsenica, could you please post the output of autoreconf --version and automake --version?

On the system I'm using where it builds successfully:

autoreconf (GNU Autoconf) 2.69
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+/Autoconf: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>, <http://gnu.org/licenses/exceptions.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by David J. MacKenzie and Akim Demaille.

automake (GNU automake) 1.15
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later <http://gnu.org/licenses/gpl-2.0.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Tom Tromey <tromey@redhat.com>

I suspect the version of one or both of those autotools programs is too old.

Oh, and please include the output of libtoolize --version too.

On our system:

libtoolize (GNU libtool) 2.4.6.35-f003-dirty
Written by Gary V. Vaughan <gary@gnu.org>, 2003

Copyright (C) 2016 Free Software Foundation, Inc.

[nopsenica]

Package versions are CentOS 7 defaults:

autoreconf: 2.69

autoreconf (GNU Autoconf) 2.69
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+/Autoconf: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>, <http://gnu.org/licenses/exceptions.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by David J. MacKenzie and Akim Demaille.

automake: 1.15

automake (GNU automake) 1.15
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later <http://gnu.org/licenses/gpl-2.0.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Tom Tromey <tromey@redhat.com>
       and Alexandre Duret-Lutz <adl@gnu.org>.

libtoolize: 2.4.2

libtoolize (GNU libtool) 2.4.2
Written by Gary V. Vaughan <gary@gnu.org>, 2003

Copyright (C) 2011 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Interesting. Apparently our build system is getting the same error and discarding it.

Running ./configure afterwards should work.
I'll look into removing the extraneous errors from the build process, but could you try running

./configure
make clean
make

and see if it successfully builds?