Skip to content

Commit d89f490

Browse files
committed
cleanup: remove dead bytesPerValue and redundant no-op filter in Arrow reader
- bytesPerValue() was defined but never called — removed - createFragments() filtered projected columns against themselves (always identity) — simplified to pass through directly
1 parent 93e3e3b commit d89f490

File tree

1 file changed

+1
-18
lines changed

1 file changed

+1
-18
lines changed

src/readers/arrow-reader.ts

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -283,21 +283,6 @@ function parseRecordBatchMessage(buf: DataView, msgTable: number): RecordBatchMe
283283
return { length, nodes, buffers };
284284
}
285285

286-
// ---------------------------------------------------------------------------
287-
// Bytes-per-value helper
288-
// ---------------------------------------------------------------------------
289-
290-
function bytesPerValue(dtype: DataType): number {
291-
switch (dtype) {
292-
case "int8": case "uint8": return 1;
293-
case "int16": case "uint16": case "float16": return 2;
294-
case "int32": case "uint32": case "float32": return 4;
295-
case "int64": case "uint64": case "float64": return 8;
296-
case "bool": return 0; // bit-packed
297-
default: return 0; // variable-length
298-
}
299-
}
300-
301286
/** Check whether a DataType uses variable-length encoding (offsets buffer). */
302287
function isVariableLength(dtype: DataType): boolean {
303288
return dtype === "utf8" || dtype === "binary";
@@ -420,9 +405,7 @@ export class ArrowReader implements FormatReader {
420405
}
421406

422407
async createFragments(source: DataSource, projected: ColumnMeta[]): Promise<FragmentSource[]> {
423-
const projectedNames = new Set(projected.map(c => c.name));
424-
const filteredCols = projected.filter(c => projectedNames.has(c.name));
425-
return [new ArrowFragmentSource(filteredCols, source)];
408+
return [new ArrowFragmentSource(projected, source)];
426409
}
427410

428411
// -------------------------------------------------------------------------

0 commit comments

Comments
 (0)