Skip to content

Commit 83d91e5

Browse files
committed
refactor: replace miniflare with wrangler getPlatformProxy
Use wrangler's stable getPlatformProxy() API instead of direct Miniflare instantiation for R2 bucket bindings in conformance tests. Removes miniflare as a separate devDependency.
1 parent 19e09c6 commit 83d91e5

File tree

3 files changed

+5
-13
lines changed

3 files changed

+5
-13
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
"@cloudflare/workers-types": "^4.20250224.0",
3535
"@types/node": "^25.3.3",
3636
"duckdb": "^1.4.4",
37-
"miniflare": "^4.20260301.1",
3837
"typescript": "^5.7.0",
3938
"vitest": "^3.0.0",
4039
"wrangler": "^4.0.0"

pnpm-lock.yaml

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/operators-conformance.test.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import duckdb from "duckdb";
1010
import type { Row } from "./types.js";
1111
import type { AggregateOp, WindowSpec } from "./types.js";
1212
import type { QueryDescriptor } from "./client.js";
13-
import { Miniflare } from "miniflare";
13+
import { getPlatformProxy } from "wrangler";
1414
import { R2SpillBackend } from "./r2-spill.js";
1515
import {
1616
type Operator,
@@ -35,24 +35,20 @@ import {
3535

3636
let db: duckdb.Database;
3737
let con: duckdb.Connection;
38-
let mf: Miniflare;
38+
let platform: Awaited<ReturnType<typeof getPlatformProxy>>;
3939
let r2Bucket: R2Bucket;
4040

4141
beforeAll(async () => {
4242
db = new duckdb.Database(":memory:");
4343
con = new duckdb.Connection(db);
44-
mf = new Miniflare({
45-
modules: true,
46-
script: 'export default { fetch() { return new Response("ok") } }',
47-
r2Buckets: ["TEST_BUCKET"],
48-
});
49-
r2Bucket = await mf.getR2Bucket("TEST_BUCKET");
44+
platform = await getPlatformProxy();
45+
r2Bucket = platform.env.DATA_BUCKET as unknown as R2Bucket;
5046
});
5147

5248
afterAll(async () => {
5349
con.close();
5450
db.close();
55-
await mf.dispose();
51+
await platform.dispose();
5652
});
5753

5854
function duckRun(sql: string): Promise<void> {

0 commit comments

Comments
 (0)