Localization Improvement Request

[chkmyid]

The newly added PvP module has different formatting and is not localized on Korean clients.

English Format: mod.rankText:SetText(hd.rankName .. " (Rank " .. hd.rankNumber .. ")")
Korean Format: mod.rankText:SetText(hd.rankName .. " (등급 " .. hd.rankNumber .. ")")

Right now, all the basic menus are also printed in English.
Is there an effective way to localize?

[taxidriveer]

Hi chkmyid,
Thanks for the heads up, there is no current way to translate it but it's in the todo list.

[taxidriveer]

I've uploaded a new version using global strings, everything should be automatically translated now.
I'm still not happy with the spacing between each lines...

Edit: I've done a new release with localization support and a small ajustment to the layout.
I'm using https://www.townlong-yak.com/framexml/32265/GlobalStrings.lua/KR for translation, let me know if you find any issues.

[chkmyid]

"GlobalStrings.lua/KR" does not contain all words.
I've found some words of similar expression, but this is limited.
And the expressions that don't exist should be a combination of similar words. This is very inefficient.

For example
Modules/stats.lua - 6 lines

enUS ver: local mod = ex:CreateModule("Stats","Gear Statistics");
koKR ver: local mod = ex:CreateModule(STAT_CATEGORY_ATTRIBUTES,EQUIPSET_EQUIP.. " " ..STAT_CATEGORY_ATTRIBUTES);
Wouldn't this change be disruptive to other languages?

and 7 lines
mod.help = "Right Click for extended menu";
There is no way to localize the above sentences in GlobalStrings.lua.

Because this is not a Korean client-only addon, these modifications do not seem to fit.
A "Locales" folder must be created and separated by language so that it can be localized separately.

Before:
local mod = ex:CreateModule("Stats","Gear Statistics");

After:

local L = LibStub("AceLocale-3.0"):GetLocale("Examiner")
local mod = ex:CreateModule(L["Stats"],L["Gear Statistics"]);

Base locale:

local L =  LibStub:GetLibrary("AceLocale-3.0"):NewLocale("Examiner", "enUS", true)
if not L then return end
L["Stats"] = true
L["Gear Statistics"] = true

koKR locale:

local L =  LibStub:GetLibrary("AceLocale-3.0"):NewLocale("Examiner", "koKR")
if not L then return end
L["Stats"] = "능력치"
L["Gear Statistics"] = "장비 능력치"

What do you think of this?

[taxidriveer]

Hi,

Thank you for the detailed information.

I don't think using global variables will work for text on buttons, for example the translation in French is way too long and will not fit. Also some lines like "Lists gear with enchants or the lack thereof" won't be possible.

As for using Ace3 for localization support why not... I originally planned to keep this as close as Aezay version but it's starting to get a bit bigger than I originaly though.
I'll see what I can do with LibGearExam and Examiner. (I don't want two files for locals)

[chkmyid]

Please think of an effective way to localize. Thank you.