openjournals/joss-reviews/issues/6797
The code is clear and the structure seems to be consistent across the different scripts. However, I have tried to run devtools::check() and it does not work due to the following error associated with the vignettes:
Also, I have needed to install some additional dependencies for the check:
I have some minor comments:
- Due to the dependency with the “parallel” package (which is integrated in core R), RSWAT requires the latest versions of R (>4.1.1), so it needs to be added.
- There are some other dependencies that are missing and not included in the DESCRIPTION file(e.g., 'magrittr' 2.0.1 is being loaded, but >= 2.0.3 is required)
- If the selected directory (tempdir) does not exist, the package should create the folder in the system
- Consider creating a documentation website using the “pkgdown” (or a similar) package.
openjournals/joss-reviews/issues/6797
The code is clear and the structure seems to be consistent across the different scripts. However, I have tried to run devtools::check() and it does not work due to the following error associated with the vignettes:
Also, I have needed to install some additional dependencies for the check:
I have some minor comments: