Skip to content

E(z) and sigma^2 definitions #45

@ethansteelberg

Description

@ethansteelberg

Hello, I think I found a couple typos in the clustr.py that may be helpful to address.

Firstly, I think there is a typo in the definition of E(z), where instead of h it should be Omega_lambda. Also H_0 is being defined as 0.7.

Image

Secondly, when clustr.py calls run_linmix the function returns sigma but the value is assigned to the variable kelly_sigsqr. It may help to rename this to avoid confusion.

From clustr.py, line 413:

self.kelly_b, self.kelly_m, self.kelly_sigsqr = reglib.run_linmix( x=self.log_x, y=self.log_y, err_x=self.log_x_err, err_y=self.log_y_err, delta=data.delta_)

and from run_linmix in reglib.py, line 120:

sigma = np.sqrt(model.chain['sigsqr'])

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions