Prepend base in goto

[benmccann]

Describe the problem

sveltejs/eslint-plugin-svelte#679

Describe the proposed solution

Maybe can we improve interface of goto.
For example goto considers basepath automatically if base is set in config file.

Alternatives considered

No response

Importance

would make my life easier

Additional Information

No response

[PatrickG]

This would need to be configurable, since resolveRoute() already adds the base path.

[codenoid]

as long it's optional, I'm fine

[marekdedic]

Hi, seeing as this is based on a lint rule I wrote, let me add a bit of context and push back on the optionality part. If I understand things correctly, goto should only ever be used for internal navigation - so for navigating to pages that (by definition) start with the base path. In that case, it seems to me that prepending the base path is always the correct option.

I haven't really used resolveRoute so I probably don't know all its uses, but it seems to me to be just a helper you use when constructing addresses for goto (and/or pushState and replaceState?). So it would make sense for resolveRoute to not prepend the base path and leave that to goto.

Relatedly, shouldn't pushState and replaceState prepend the base path as well? It seems to me that they are also intended to only be used for internal navigation (of course, passing an empty string to them would be handled as a special case...)

[marekdedic]

Since the introduction of resolve() a few versions back, it seems to me that this issue would now basically mean that all 3 of goto(), pushState() and resolveState() would "just" call resolve() automatically :)

[PatrickG]

@marekdedic That would mean all three need to accept a params argument/property.

[teemingc]

@benmccann do we still want to do this so that people don't have to do goto(resolve(...)) ?

[marekdedic]

Drive-by comment: How about getting rid of resolve() altogether? It seems to me like a foot-gun (hence the svelte/no-navigation-without-resolve lint rule...). However, that would require 2 things:

• This issue - auto-resolve for goto(), pushState(), replaceState()
• Somehow solving links. At the moment, <a href="..."> links can be used for both internal and external navigation. For internal navigation, you should AFAIK almost always use resolve with them (exceptions being pure query/fragment links). But for external, you shouldn't. Maybe it's time to introduce a <Link> component? Then that one could handle the logic for internal/external navigation and we could get rid of resolve().