Skip to content

Can't build on node 0.12 #22

@chrisyip

Description

@chrisyip

node-xmpp <=0.15 doesn't support node 0.12, node-gyp will throw errors.

So I tried to upgrade node-xmpp to 1.0.0-alpha2. Build succeeded, but I could not pass the tests:

> superfeedr@0.2.0 test /Users/Chris/Workspace/node/superfeedr-node
> export NODE_ENV=test; mocha

Cannot load StringPrep-0.7.0 bindings (using fallback). You may need to `npm install node-stringprep`
Cannot load StringPrep-0.7.0 bindings (using fallback). You may need to `npm install node-stringprep`

  createCredentials() is deprecated, use tls.createSecureContext instead
/Users/Chris/Workspace/node/superfeedr-node/node_modules/mocha/lib/runner.js:93
  test.failed = true;
              ^
TypeError: Cannot set property 'failed' of undefined
    at Runner.fail (/Users/Chris/Workspace/node/superfeedr-node/node_modules/mocha/lib/runner.js:93:15)
    at process.<anonymous> (/Users/Chris/Workspace/node/superfeedr-node/node_modules/mocha/lib/runner.js:354:10)
    at emitOne (events.js:77:13)
    at process.emit (events.js:169:7)
    at process._fatalException (node.js:211:26)
    at emitOne (events.js:77:13)
    at Connection.emit (events.js:169:7)
    at Connection.onStanza (/Users/Chris/Workspace/node/superfeedr-node/node_modules/node-xmpp/node_modules/node-xmpp-core/lib/connection.js:352:14)
    at StreamParser.<anonymous> (/Users/Chris/Workspace/node/superfeedr-node/node_modules/node-xmpp/node_modules/node-xmpp-core/lib/connection.js:221:14)
    at emitOne (events.js:77:13)
    at StreamParser.emit (events.js:169:7)
    at SaxExpat.<anonymous> (/Users/Chris/Workspace/node/superfeedr-node/node_modules/node-xmpp/node_modules/node-xmpp-core/lib/stream_parser.js:56:22)
    at emitOne (events.js:77:13)
    at SaxExpat.emit (events.js:169:7)
    at null.<anonymous> (/Users/Chris/Workspace/node/superfeedr-node/node_modules/node-xmpp/node_modules/ltx/lib/sax/sax_expat.js:16:14)
    at emitOne (events.js:77:13)
    at emit (events.js:169:7)
    at Parser.parse (/Users/Chris/Workspace/node/superfeedr-node/node_modules/node-xmpp/node_modules/node-expat/lib/node-expat.js:23:22)
    at SaxExpat.write (/Users/Chris/Workspace/node/superfeedr-node/node_modules/node-xmpp/node_modules/ltx/lib/sax/sax_expat.js:27:22)
    at StreamParser.write (/Users/Chris/Workspace/node/superfeedr-node/node_modules/node-xmpp/node_modules/node-xmpp-core/lib/stream_parser.js:125:21)
    at Connection.onData (/Users/Chris/Workspace/node/superfeedr-node/node_modules/node-xmpp/node_modules/node-xmpp-core/lib/connection.js:288:21)
    at emitOne (events.js:82:20)
    at TLSSocket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:145:16)
    at TLSSocket.Readable.push (_stream_readable.js:109:10)
    at TLSWrap.onread (net.js:509:20)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions