Skip to content

Lintrunner not applying edits, fails check after manual fix #92

@trichmo

Description

@trichmo

Using lintrunner on pytorch, I get an error if the file has no lint errors or if the file tries to apply fixes to lint errors.
The reported error doesn't happen across the pytorch repo, but this specific file is at least once instance.

Initially, running lintrunner torch/csrc/lazy/core/shape_inference.cpp would show lint errors, but lintrunner -a would not fix them. After manually fixing the errors so lintrunner torch/csrc/lazy/core/shape_inference.cpp passed, another error was produced when checking if the are no more lint issues.

Opening issue here as indicated by the message "Linter failed. This a bug, please file an issue against the linter maintainer."

Running:
lintrunner torch/csrc/lazy/core/shape_inference.cpp -> produces suggested file changes (e.g. simple lint error no space in else{)

lintrunner -a -> produces error message which also states it successfully applies all patches

Manually fix lint erros

lintrunner torch/csrc/lazy/core/shape_inference.cpp -> produces error`

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions