Skip to content

Colons in filenames #15

@noahheck

Description

@noahheck

We have a development team hosting VMs on a Windows system with source files shared across a VirtualBox shared folder. The naming convention for cache files across that share are not valid because they contain the colon (:) character as part of the filename key (e.g., :hits or :time ). Keys are established as Class Constants (e.g., https://github.com/sunspikes/php-ratelimiter/blob/master/src/Throttle/Throttler/FixedWindowThrottler.php#L32).

Microsoft docs (https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file) show a set of invalid filename characters, including the following:

  • < (less than)
  • > (greater than)
  • : (colon)
  • " (double quote)
  • / (forward slash)
  • \ (backslash)
  • | (vertical bar or pipe)
  • ? (question mark)
  • * (asterisk)

Can we update the key names to not include any reserved characters? My suggestion would be to use the _ (underscore) character for separation of the filename components, but I'm open for suggestions.

I'm happy to do this work and submit it back if it will be accepted.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions