-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Labels
Description
Description
Hello,
Min version calculation initial value should be fixed in WcVersion.java. The current implementation (checked
out on the date of bug submission) always keeps min version at 0.
Also the wrong version number item is used for calculating the revision range.
Please, consider changing the code according to e.g. the following diff to keep it in sync with svnversion's
output:
202c202
< protected long minRevision = 0;
---
> protected long minRevision = Long.MAX_VALUE;
248,256c248,258
< SVNRevision.Number rev = status.getLastChangedRevision();
< long revNum = (rev != null) ? rev.getNumber() : 0;
< if( revNum > this.maxRevision ) {
< this.maxRevision = revNum;
< }
<
< if( revNum < this.minRevision ) {
< this.minRevision = revNum;
< }
---
> SVNRevision.Number rev = status.getRevision();
> if (rev != null) {
> long revNum = rev.getNumber();
> if( revNum > this.maxRevision ) {
> this.maxRevision = revNum;
> }
>
> if( revNum < this.minRevision ) {
> this.minRevision = revNum;
> }
> }
266c268,271
< if( (this.minRevision > 0) && (this.minRevision != this.maxRevision) ) {
---
> if (this.minRevision > this.maxRevision) {
> this.minRevision = this.maxRevision;
> }
> else if( (this.minRevision > 0) && (this.minRevision != this.maxRevision) ) {
Metadata Imported from Tigris (Issue 1403)
- Creation Date: 2012-04-12 16:56:33
- Reporter: johndoe0413
- Subcomponent: svnant
- Version: unspecified
- Milestone: not determined
- Keywords:
- Cc: