Do we make some changes to C# warning ca1063? with Stride.Core.DisposeBase #2384
Closed
Arc-huangjingtong
started this conversation in
General
Replies: 1 comment
-
|
We can also seal the class, which I think would make sense for the other instances of this warning we have in our codebase. No one's taking care of this as far as I know, feel free to tackle this one |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
C# warning CA1063
https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063
oringin code in Stride.Core.DisposeBase
modified
Because some operations will prevent [System.IDisposable] from being called normally.
such as override Finalize ?
Beta Was this translation helpful? Give feedback.
All reactions