-
Notifications
You must be signed in to change notification settings - Fork 24
Add node-level metrics endpoint for Kafka clusters #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MikeEdgar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be heading in the right direction, thanks @hemahg . I had one comment about the response format for consistency.
api/src/main/java/com/github/streamshub/console/api/NodesResource.java
Outdated
Show resolved
Hide resolved
c9dd02d to
3937d68
Compare
MikeEdgar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I put a few comments on naming, issues from Sonar, and a possible way to consolidate the mapping of metrics returned from Prometheus.
api/src/main/java/com/github/streamshub/console/api/model/NodeMetricsEntry.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/github/streamshub/console/api/model/NodeMetricsEntry.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/github/streamshub/console/api/service/NodeService.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/github/streamshub/console/api/model/NodeMetricsEntry.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/github/streamshub/console/api/service/NodeService.java
Outdated
Show resolved
Hide resolved
MikeEdgar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: hemahg <hhg@redhat.com>
Signed-off-by: hemahg <hhg@redhat.com>
0178238 to
7a0579d
Compare
|



Add node-level metrics endpoint for Kafka clusters