Skip to content
This repository was archived by the owner on Apr 1, 2024. It is now read-only.
This repository was archived by the owner on Apr 1, 2024. It is now read-only.

PR-20832: [improve][broker] Heartbeat topic enable checkMessageExpire #5835

@streamnativebot

Description

@streamnativebot

url: apache#20832

Motivation

Running pulsar cluster for a long time, we found there are thousands of ledgers of heartbeat topic. The reason is heartbeat topic do not clean the expired message because it is systemTopic. The behaviour change since this pr apache#13611.

I think it is no need to keep heartbeat topic message permanently and we'd better clean the expired message and the ledger.

Modifications

modify checkMessageExpire()

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions